Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 )
Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu ...................................................................... Patch Set 11: (2 comments) Apologize for not taking a look earlier. Lot of the changes looked specific to Impala. I mainly looked at Impala BBF code that was updated to invoke one from kudu-util. http://gerrit.cloudera.org:8080/#/c/15683/11/be/src/util/bloom-filter.cc File be/src/util/bloom-filter.cc: http://gerrit.cloudera.org:8080/#/c/15683/11/be/src/util/bloom-filter.cc@71 PS11, Line 71: if (directory_in_size == 0) Could you clarify with a comment in what case would directory_in_size be 0 since this Init variant should really be used for deserialization case. http://gerrit.cloudera.org:8080/#/c/15683/11/be/src/util/bloom-filter.cc@201 PS11, Line 201: if (is_allocated_) { : LOG(DFATAL) << "Each call to AllocateBuffer must have a corresponding call " : << "to FreeBuffer."; : Close(); // Ensure that any previously allocated memory is released. : } Same instance of allocator can be used for multiple BBFs. So this doesn't look right to me. With that in mind, I don't see need for is_allocated_member variable. ImpalaBloomFilterBufferAllocator should be a simple wrapper on top of Impala's default buffer pool and should be implemented as a singleton. -- To view, visit http://gerrit.cloudera.org:8080/15683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9100076f68ea299ddb6ec8bc027cac7a47f5d754 Gerrit-Change-Number: 15683 Gerrit-PatchSet: 11 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 08 May 2020 00:11:08 +0000 Gerrit-HasComments: Yes
