Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15868 )
Change subject: IMPALA-9729: consistent GetExecSummary() behaviour ...................................................................... IMPALA-9729: consistent GetExecSummary() behaviour Before IMPALA-9380, GetExecSummary() for archived queries without a coordinator returned a blank TExecSummary, but for in-flight queries it returned a "not found" error. This was masked by the synchronous query unregistration, but now has made an impala-shell test flaky, because the close() RPC returns to the shell before the query is archived, so the following GetExecSummary() call may go down either code path. This change makes the behaviour consistent for both code paths and preserves impala-shell behaviour. Testing: Looped TestImpalaShell.test_summary to make sure flakiness was fixed. Change-Id: If2b2ab118c4769e80284b2a3390577dd5f5e888b Reviewed-on: http://gerrit.cloudera.org:8080/15868 Reviewed-by: Thomas Tauber-Marshall <[email protected]> Tested-by: Tim Armstrong <[email protected]> --- M be/src/service/impala-server.cc M common/thrift/ImpalaService.thrift 2 files changed, 7 insertions(+), 1 deletion(-) Approvals: Thomas Tauber-Marshall: Looks good to me, approved Tim Armstrong: Verified -- To view, visit http://gerrit.cloudera.org:8080/15868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If2b2ab118c4769e80284b2a3390577dd5f5e888b Gerrit-Change-Number: 15868 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
