Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15867 )
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/15867/1/docs/topics/impala_logging.xml File docs/topics/impala_logging.xml: http://gerrit.cloudera.org:8080/#/c/15867/1/docs/topics/impala_logging.xml@44 PS1, Line 44: <p> The Impala logs record information about: </p> Just curious: there are many formatting changes like these. Are they nessasary, i.e. the old codes violating any code styles? http://gerrit.cloudera.org:8080/#/c/15867/1/docs/topics/impala_logging.xml@195 PS1, Line 195: By default this : page displays the current running log level of the service. The current log levels are not shown in this page. But users can query the log4j log level of "root" or "org.apache.impala" by using the "Get Java Log Level" button. http://gerrit.cloudera.org:8080/#/c/15867/1/docs/topics/impala_logging.xml@204 PS1, Line 204: Log Levels. Can we mention that this is a one character info and their meaning are "I=INFO, W=WARNING, E=ERROR, F=FATAL" ? http://gerrit.cloudera.org:8080/#/c/15867/1/docs/topics/impala_logging.xml@208 PS1, Line 208: PID/TID of the process/thread. I think there are no PID for process. http://gerrit.cloudera.org:8080/#/c/15867/1/docs/topics/impala_logging.xml@211 PS1, Line 211: user-specified remove this word? Logs are generated by the system(impala). -- To view, visit http://gerrit.cloudera.org:8080/15867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd Gerrit-Change-Number: 15867 Gerrit-PatchSet: 1 Gerrit-Owner: Shajini Thayasingh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 08 May 2020 04:16:40 +0000 Gerrit-HasComments: Yes
