Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15817 )

Change subject: IMPALA-9628: Refactor bootstrap_system.sh
......................................................................


Patch Set 4:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/15817/4/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/15817/4/bin/bootstrap_system.sh@164
PS4, Line 164:       
https://downloads.apache.org/maven/maven-3/3.5.4/binaries/apache-maven-3.5.4-bin.tar.gz
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/15817/4/bin/bootstrap_system.sh@166
PS4, Line 166:       
'2a803f578f341e164f6753e410413d16ab60fabe31dc491d1fe35c984a5cce696bc71f57757d4538fe7738be04065a216f3ebad4ef7e0ce1bb4c51bc36d6be86
 apache-maven-3.5.4-bin.tar.gz'
line too long (166 > 90)


http://gerrit.cloudera.org:8080/#/c/15817/4/bin/bootstrap_system.sh@189
PS4, Line 189:   if ! [[ 1 = $(sudo -u postgres psql -At -c "SELECT count(*) 
FROM pg_roles WHERE rolname = 'hiveuser';") ]]
line too long (108 > 90)


http://gerrit.cloudera.org:8080/#/c/15817/4/bin/bootstrap_system.sh@235
PS4, Line 235:   # In Docker, one can change /etc/hosts as above but not with 
sed -i. The error message is
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/15817/4/bin/bootstrap_system.sh@282
PS4, Line 282:     git clone --branch master 
https://github.com/cloudera/impala-lzo.git "$IMPALA_LZO_HOME"
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/15817/4/bin/bootstrap_system.sh@432
PS4, Line 432:     
'487dbd1d7f678a92924ba884a57e910ccb4fe565c554278795a8fdfc80c4e88d81ebc2ccecb5a8f353f0b2076572bb921499a2cadb064e0f44fc406a3c31da20
  apache-ant-1.9.14-bin.tar.gz'
line too long (164 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/15817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9e4309d6648a160b58ebc1e18043afe4110789b
Gerrit-Change-Number: 15817
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Garaguly <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Comment-Date: Fri, 08 May 2020 10:04:40 +0000
Gerrit-HasComments: Yes

Reply via email to