Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 )
Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes ...................................................................... Patch Set 32: (1 comment) Fixing a few issues that are causing the test failures: (1) Removed a DCHECK (see comment below) (2) Fixed a bug where GetQueryHandle was not passing return_unregistered to GetQueryDriver Ran a bunch of more tests locally, and things look good: * Re-ran the stress tests for tpcds and tpch * Looped the new tests overnight and no failures Did some additional cleanup of code comments, removing unnecessary imports, minor-refactoring, etc. http://gerrit.cloudera.org:8080/#/c/14824/26/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/14824/26/be/src/runtime/coordinator.cc@511 PS26, Line 511: if (!failed_backend_states.empty()) { > Done I had to remove the DCHECK because it caused a crash. Turns out that because of the IsAborted() check above, its possible for this list to be empty. Tests that use the EXEC_SERIALIZE_FRAGMENT_INFO Debug Action trigger the DCHECK. -- To view, visit http://gerrit.cloudera.org:8080/14824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e4a0e72a9bf8ec10b91639aefd81bef17886ddd Gerrit-Change-Number: 14824 Gerrit-PatchSet: 32 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Fri, 15 May 2020 14:47:57 +0000 Gerrit-HasComments: Yes
