Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15798 )
Change subject: IMPALA-9382: part 1: transposed profile prototype ...................................................................... Patch Set 6: (15 comments) http://gerrit.cloudera.org:8080/#/c/15798/6/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/15798/6/be/src/util/runtime-profile-counters.h@416 PS6, Line 416: int64_t min_value() const { return min_value_; } I think maintaining the min and max value on each update is a mistake - it is not correct if the counter is updated more than once, and it adds complexity to the code. I think we should instead compute these stats on demand when pretty-printing the profile. http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile-counters.h@392 PS4, Line 392: /// TODO: IMPALA-9382: rename counter. CounterVector? AggregatedCounter? > Update comment Done http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile-counters.h@499 PS4, Line 499: > This Done http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile.h File be/src/util/runtime-profile.h: http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile.h@370 PS4, Line 370: > Update this Done http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile.h@744 PS4, Line 744: int idx); > pluralise Done http://gerrit.cloudera.org:8080/#/c/15798/2/be/src/util/runtime-profile.h File be/src/util/runtime-profile.h: http://gerrit.cloudera.org:8080/#/c/15798/2/be/src/util/runtime-profile.h@193 PS2, Line 193: /// Return the number of input instances that contributed to this profile. > Do this Done http://gerrit.cloudera.org:8080/#/c/15798/2/be/src/util/runtime-profile.h@349 PS2, Line 349: }; > typo Done http://gerrit.cloudera.org:8080/#/c/15798/1/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/15798/1/be/src/util/runtime-profile.cc@2203 PS1, Line 2203: return distinct_vals; > Move aggregated logic down here? Done http://gerrit.cloudera.org:8080/#/c/15798/2/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/15798/2/be/src/util/runtime-profile.cc@222 PS2, Line 222: bool indent = nodes[*idx].indent; > bad comment Done http://gerrit.cloudera.org:8080/#/c/15798/2/be/src/util/runtime-profile.cc@570 PS2, Line 570: double local_time_frac = > Why was it the old way? Done http://gerrit.cloudera.org:8080/#/c/15798/2/be/src/util/runtime-profile.cc@1056 PS2, Line 1056: profile->PrettyPrint(s, prefix + (indent ? " " : "")); > ADd todo Done http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile.cc@541 PS4, Line 541: for (int i = 0; i < children_.size(); ++i) { > remove logs Done http://gerrit.cloudera.org:8080/#/c/15798/4/be/src/util/runtime-profile.cc@1871 PS4, Line 1871: tcounter->min_value[i] = counter->min_; > thisnn Done http://gerrit.cloudera.org:8080/#/c/15798/4/common/thrift/RuntimeProfile.thrift File common/thrift/RuntimeProfile.thrift: http://gerrit.cloudera.org:8080/#/c/15798/4/common/thrift/RuntimeProfile.thrift@183 PS4, Line 183: // These fields are not used in aggregated profile nodes, i.e. profile V2, > This isn't really accurate Done http://gerrit.cloudera.org:8080/#/c/15798/4/common/thrift/RuntimeProfile.thrift@226 PS4, Line 226: // for the fragment is also included with averaged counter values. > Mention this is experimental Done -- To view, visit http://gerrit.cloudera.org:8080/15798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0838c6a0872f57c696267ff4e92d29c08748eb7a Gerrit-Change-Number: 15798 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 16 May 2020 01:08:53 +0000 Gerrit-HasComments: Yes
