Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15887 )
Change subject: IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET_TABLES in LocalCatalog ...................................................................... Patch Set 6: (1 comment) > Patch Set 6: > > (1 comment) > > The latest patch looks good to me except for the comment below. Also, curious > to know if we still need IMPALA-9670 given now we will always fetch the type > and comments. We still need IMPALA-9670. After this patch, if the table is loaded in catalogd, coordinators can show its correct type and comment regardless whether it is loaded in local catalog. But if the table is unloaded in catalogd, we are still using the default table type and comment. http://gerrit.cloudera.org:8080/#/c/15887/6/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/15887/6/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@721 PS6, Line 721: invalidateStaleTableList(dbName.toLowerCase(), ref); > Why do we need this? If the table type or comment has changed since we load Sorry for not leaving a comment. This is the only point that makes this patch a little complex: We will receive a topic update in 2s (default statestore update frequency). After the table is loaded here and before the invalidation arrives, the stale tablelist will still be used. So GetTable op right after a DESCRIBE query will still get the stale type and comment. This can be reflected by test failure of test_hs2.test_get_tables. There are some test failures due to this. Will add the comment and fix the tests. -- To view, visit http://gerrit.cloudera.org:8080/15887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2180c603f061838347936f718cd4a0257d82e633 Gerrit-Change-Number: 15887 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Sat, 16 May 2020 02:00:09 +0000 Gerrit-HasComments: Yes
