Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15933 )
Change subject: IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version ...................................................................... Patch Set 1: Code-Review+2 (1 comment) This looks good to me. See my comment about the *_URL env variables. http://gerrit.cloudera.org:8080/#/c/15933/1/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/15933/1/bin/impala-config.sh@223 PS1, Line 223: export CDP_AVRO_JAVA_URL=${CDP_AVRO_JAVA_URL-} Nit: The *_URL env variables are used by bootstrap_toolchain.py. If we aren't downloading anything (i.e. this is maven-only), then you only need the version and can omit the URL variables. -- To view, visit http://gerrit.cloudera.org:8080/15933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49c7c5832b5ba53a00b098642f6c64616eb944bd Gerrit-Change-Number: 15933 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Mon, 18 May 2020 18:19:54 +0000 Gerrit-HasComments: Yes
