Zoltan Garaguly has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15898 )

Change subject: IMPALA-8680: Docker-based tests fail to archive the minicluster 
component logs
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15898/3/docker/entrypoint.sh
File docker/entrypoint.sh:

http://gerrit.cloudera.org:8080/#/c/15898/3/docker/entrypoint.sh@319
PS3, Line 319: find /logs -xtype
> There is also another problem here (not covered in the original ticket): Fo
I agree with the necessity to add copy_cluster_logs call to test_suite() 
function as well in order to have the cluster logs for test containers too.
On the other hand I do not understand the point of creating symlinks in test 
containers because the goal of copy_cluster_logs function is exactly to get rid 
of this symlink and copy the original content (the cluster logs) in the folder 
where the symlink was before. The copy happens also in case when symlink was 
not there.



--
To view, visit http://gerrit.cloudera.org:8080/15898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23e25d42992cec47c593dc388bcf0bcef828c05e
Gerrit-Change-Number: 15898
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Garaguly <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Zoltan Garaguly <[email protected]>
Gerrit-Comment-Date: Wed, 20 May 2020 08:27:42 +0000
Gerrit-HasComments: Yes

Reply via email to