Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15854 )
Change subject: IMPALA-9597: Eliminate redundant Ranger audits for column masking ...................................................................... Patch Set 14: Code-Review+1 (1 comment) lgtm, I have only one potential perf related comment, I can upgrade to +2 if that is resolved http://gerrit.cloudera.org:8080/#/c/15854/14/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationContext.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationContext.java: http://gerrit.cloudera.org:8080/#/c/15854/14/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationContext.java@70 PS14, Line 70: plugin.getUnfilteredMaskNames(Arrays.asList("MASK_NONE") This could be moved outside the loop. I don't know if creating this list is costly, but it seems a safer bet to do it only once. -- To view, visit http://gerrit.cloudera.org:8080/15854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42d60130fba93d63fbc36949f2bf746b7ae2497d Gerrit-Change-Number: 15854 Gerrit-PatchSet: 14 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 22 May 2020 09:25:11 +0000 Gerrit-HasComments: Yes
