Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/15984 )
Change subject: IMPALA-9775: Fix test failure in TestAcid.test_acid_heartbeats ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15984/1/fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java File fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java: http://gerrit.cloudera.org:8080/#/c/15984/1/fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java@52 PS1, Line 52: // But we have to set sleep interval not beyond 60 seconds for carrying through the : // unit test case TestAcid.test_acid_heartbeats (IMPALA-9775). > Hive's heartbeat wait time (timeout / 2) is even greater than Impala's (tim It's better to set an upper limit. Otherwise user may set an unreasonable value. http://gerrit.cloudera.org:8080/#/c/15984/1/tests/query_test/test_acid.py File tests/query_test/test_acid.py: http://gerrit.cloudera.org:8080/#/c/15984/1/tests/query_test/test_acid.py@191 PS1, Line 191: (sleep(200000) > You need to increase this value and MAX_ATTEMPTS. It'd be nice to do it bas For current code, TestAcid.test_acid_heartbeats take 13 minutes. When increase sleep time from 200000 to 320000, the test take 20 minutes. -- To view, visit http://gerrit.cloudera.org:8080/15984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7922797d7e3ce94a2c8948211245f4e77fdb08b7 Gerrit-Change-Number: 15984 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 25 May 2020 19:47:53 +0000 Gerrit-HasComments: Yes
