Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15958 )
Change subject: IMPALA-9737: fix reservation accounting bug in PHJ ...................................................................... IMPALA-9737: fix reservation accounting bug in PHJ This bug would only impact spilling queries with mt_dop > 0, where there is a separate builder and reservation needs to be transferred back to the builder. The bug was that 'probe_batch_' could own buffers that were using reservation from the PartitionedHashJoinNode. This reservation needs to be transferred back to the PartitionedHashJoinBuilder via ReturnReservation(). Therefore we need to clean up the batches before calling ReturnReservation(). Change-Id: Ia1619ad642628b64ed57e6f85e0755a128bafdb5 Reviewed-on: http://gerrit.cloudera.org:8080/15958 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Csaba Ringhofer <[email protected]> --- M be/src/exec/partitioned-hash-join-node.cc 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Verified Csaba Ringhofer: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia1619ad642628b64ed57e6f85e0755a128bafdb5 Gerrit-Change-Number: 15958 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
