Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15998 )

Change subject: IMPALA-9777: Set hive.optimize.sort.dynamic.partition to true 
for dynamic inserts
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

Looks good. It's always cool when a one-liner fixes something big like this.

http://gerrit.cloudera.org:8080/#/c/15998/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15998/3//COMMIT_MSG@7
PS3, Line 7: Set hive.optimize.sort.dynamic.partition to true for dynamic 
inserts
           :
           : This sets hive.optimize.sort.dynamic.partition to true by default 
during
           : data load. This option takes effect during Hive dynamic 
partitioning
           : inserts.
Since we removed the code setting it for most inserts, let's update the message 
to mention that this is only for text tpcds.store_sales.



--
To view, visit http://gerrit.cloudera.org:8080/15998
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b7c0ec40a02da2640fae20cf640517fd1f4fef
Gerrit-Change-Number: 15998
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Sahil Takiar <[email protected]>
Gerrit-Comment-Date: Sun, 31 May 2020 17:42:04 +0000
Gerrit-HasComments: Yes

Reply via email to