Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 )
Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16008/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/16008/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1850 PS2, Line 1850: String reason nit: could you keep "reason" as the last parameter to be consistent with other method definitions? http://gerrit.cloudera.org:8080/#/c/16008/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1850 PS2, Line 1850: public Table getOrLoadTable(String dbName, String tblName, String reason, : ValidWriteIdList validWriteIdList I see many lines of the change are adding a default null value to the new parameter. What about adding this parameter in an overload? So we don't need to touch existing callers of this. I.e. public Table getOrLoadTable(String dbName, String tblName, String reason) throws CatalogException { return getOrLoadTable(dbName, tblName, null, reason); } public Table getOrLoadTable(String dbName, String tblName, ValidWriteIdList validWriteIdList, String reason) throws CatalogException { ... } -- To view, visit http://gerrit.cloudera.org:8080/16008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied2c7c3cb2009c407e8fbc3af4722b0d34f57c4a Gerrit-Change-Number: 16008 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 02 Jun 2020 22:13:15 +0000 Gerrit-HasComments: Yes
