Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16020 )
Change subject: IMPALA-9318: Add admission control setting to cap MT_DOP ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16020/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16020/3//COMMIT_MSG@16 PS3, Line 16: unlimited MT_DOP do you mean there is no limit applied like with negative value? http://gerrit.cloudera.org:8080/#/c/16020/3/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/16020/3/be/src/service/impala-server.cc@914 PS3, Line 914: EnforceMaxMtDop since the config values can change while the query is in admission controller (either being assessed or in queue) should we reject the queries that have an mt_dop set higher at that point (even if it was overridden earlier)? Some context: the admission controller fetches the new config every time it assesses the query for admission which includes the first time the query is sent to the admission controller and also every time it gets dequeued. http://gerrit.cloudera.org:8080/#/c/16020/3/testdata/workloads/functional-query/queries/QueryTest/max-mt-dop.test File testdata/workloads/functional-query/queries/QueryTest/max-mt-dop.test: http://gerrit.cloudera.org:8080/#/c/16020/3/testdata/workloads/functional-query/queries/QueryTest/max-mt-dop.test@7 PS3, Line 7: select count(*) from tpch.lineitem; nit: we can probably just use "select 1" here and below and save a few seconds on execution. -- To view, visit http://gerrit.cloudera.org:8080/16020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3affb127a5dca517591323f2b1c880aa4b38badd Gerrit-Change-Number: 16020 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 02 Jun 2020 23:44:01 +0000 Gerrit-HasComments: Yes
