Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16029 )
Change subject: IMPALA-9782: fix Kudu DML with mt_dop ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16029/2/be/src/exprs/kudu-partition-expr.cc File be/src/exprs/kudu-partition-expr.cc: http://gerrit.cloudera.org:8080/#/c/16029/2/be/src/exprs/kudu-partition-expr.cc@74 PS2, Line 74: unique_ptr<KuduPartitionExprCtx> ctx = make_unique<KuduPartitionExprCtx>(); I don't think this is used anywhere? http://gerrit.cloudera.org:8080/#/c/16029/2/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/16029/2/tests/query_test/test_kudu.py@63 PS2, Line 63: # The kudu_read_mode of READ_LATEST does not provide high enough consistency for : # these tests. : # The default read mode of READ_LATEST does not provide high enough consistency for : # these tests. typo -- To view, visit http://gerrit.cloudera.org:8080/16029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7e86894da9dbcb3b69f7db236c841ecc08dbf1a Gerrit-Change-Number: 16029 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Thu, 04 Jun 2020 19:01:48 +0000 Gerrit-HasComments: Yes
