Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )
Change subject: IMPALA-8860: Improve /log_level usability on WebUI ...................................................................... Patch Set 7: (2 comments) Apologies for the delay. Based on my understanding the 'getLogLevel()' becomes deprecated and will not be called anymore. This method and its thrift object could be removed, other than this LGTM! http://gerrit.cloudera.org:8080/#/c/15903/7/common/thrift/Logging.thrift File common/thrift/Logging.thrift: http://gerrit.cloudera.org:8080/#/c/15903/7/common/thrift/Logging.thrift@38 PS7, Line 38: struct TGetJavaLogLevelParams { : 1: required string class_name : } I think this becomes unused as 'getLogLevel()' will not be called anymore. http://gerrit.cloudera.org:8080/#/c/15903/7/fe/src/main/java/org/apache/impala/util/GlogAppender.java File fe/src/main/java/org/apache/impala/util/GlogAppender.java: http://gerrit.cloudera.org:8080/#/c/15903/7/fe/src/main/java/org/apache/impala/util/GlogAppender.java@145 PS7, Line 145: /** : * Get the log4j log level corresponding to a serialized TGetJavaLogLevelParams. : */ : public static String getLogLevel(byte[] serializedParams) throws ImpalaException { : TGetJavaLogLevelParams thriftParams = new TGetJavaLogLevelParams(); : JniUtil.deserializeThrift(protocolFactory_, thriftParams, serializedParams); : String className = thriftParams.getClass_name(); : if (Strings.isNullOrEmpty(className)) return null; : return Logger.getLogger(className).getEffectiveLevel().toString(); : } I think this can be removed, as far as I can see it was only called by the BE earlier, which is now calling the 'getLogLevels()' method. -- To view, visit http://gerrit.cloudera.org:8080/15903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33 Gerrit-Change-Number: 15903 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Garaguly <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Zoltan Garaguly <[email protected]> Gerrit-Comment-Date: Mon, 08 Jun 2020 11:47:39 +0000 Gerrit-HasComments: Yes
