Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16039 )
Change subject: IMPALA-9077: Remove scalable admission control configs ...................................................................... Patch Set 4: Code-Review+2 (2 comments) This looks pretty straightforward. http://gerrit.cloudera.org:8080/#/c/16039/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16039/4//COMMIT_MSG@14 PS4, Line 14: This patch reverts the functionality related to those configs but Nit: I would say it "removes" the functionality rather than "reverts". A revert is usually what we say for a temporary removal? I suppose you could also explain that this removal is to make it easier to enhance Admission Control using Executor Groups which has turned out to be a useful building block. http://gerrit.cloudera.org:8080/#/c/16039/4/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/16039/4/be/src/scheduling/admission-controller.cc@1824 PS4, Line 1824: bool AdmissionController::PoolLimitsRunningQueriesCount(const TPoolConfig& pool_config) { I see you are keeping some utility functions like this. Probably they do increase the readability of the code so I agree with this. -- To view, visit http://gerrit.cloudera.org:8080/16039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9bd63f03758a6c4eebb99c64ee67e60cb56b5ac Gerrit-Change-Number: 16039 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 08 Jun 2020 23:28:31 +0000 Gerrit-HasComments: Yes
