Zoltan Garaguly has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )
Change subject: IMPALA-8860: Improve /log_level usability on WebUI ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/15903/7/common/thrift/Logging.thrift File common/thrift/Logging.thrift: http://gerrit.cloudera.org:8080/#/c/15903/7/common/thrift/Logging.thrift@38 PS7, Line 38: // - return value as a list of Java classes with corresponding : // logging levels set before using GlogAppender.getLogLevels() : s > I think this becomes unused as 'getLogLevel()' will not be called anymore. Done http://gerrit.cloudera.org:8080/#/c/15903/7/fe/src/main/java/org/apache/impala/util/GlogAppender.java File fe/src/main/java/org/apache/impala/util/GlogAppender.java: http://gerrit.cloudera.org:8080/#/c/15903/7/fe/src/main/java/org/apache/impala/util/GlogAppender.java@145 PS7, Line 145: * Sets the logging level of a class as per serialized TSetJavaLogLevelParams. : */ : public static String setLogLevel(byte[] serializedParams) throws ImpalaException { : TSetJavaLogLevelParams thriftParams = new TSetJavaLogLevelParams(); : JniUtil.deserializeThrift(protocolFactory_, thriftParams, serializedParams); : String className = thriftParams.getClass_name(); : String logLevel = thriftParams.getLog_level(); : if (Strings.isNullOrEmpty(className) || Strings.isNullOrEmpty(logLevel)) return null; : // Level.toLevel() returns DEBUG for an incorrect logLevel input. : > I think this can be removed, as far as I can see it was only called by the Done -- To view, visit http://gerrit.cloudera.org:8080/15903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33 Gerrit-Change-Number: 15903 Gerrit-PatchSet: 12 Gerrit-Owner: Zoltan Garaguly <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Zoltan Garaguly <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2020 08:00:28 +0000 Gerrit-HasComments: Yes
