Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16046 )
Change subject: IMPALA-9341: Set delegateAdmin to false for REVOKE without GRANT OPTION ...................................................................... Patch Set 1: Code-Review+2 (2 comments) I only have some comments about the commit message. http://gerrit.cloudera.org:8080/#/c/16046/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16046/1//COMMIT_MSG@30 PS1, Line 30: In this regard, as a workaround, we set : delegateAdmin in the GrantRevokeRequest to false for a REVOKE statement : without the GRANT OPTION. The code contains isGrant && withGrantOpt, which means it is never true for revokes, even if GRANT OPTION is set. http://gerrit.cloudera.org:8080/#/c/16046/1//COMMIT_MSG@52 PS1, Line 52: the alternative that is less efficient. The link to the alternative solution could be added here: https://gerrit.cloudera.org/#/c/16013/ -- To view, visit http://gerrit.cloudera.org:8080/16046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19ff45a5a30293e9c6cf35b22ea4aa5cb10355c9 Gerrit-Change-Number: 16046 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2020 11:09:09 +0000 Gerrit-HasComments: Yes
