Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15997 )
Change subject: IMPALA-2658: Extend the NDV function to accept a precision ...................................................................... Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/15997/16/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/15997/16/be/src/exprs/aggregate-functions-ir.cc@1449 PS16, Line 1449: // precision = log2(size), or size = 2^precision. Given the size, precision is line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/16/be/src/exprs/aggregate-functions-ir.cc@1606 PS16, Line 1606: static constexpr int64_t BUCKET_SIZE = sizeof(int64_t) + AggregateFunctions::DEFAULT_HLL_LEN; line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/15997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48a4517bd0959f7021143073d37505a46c551a58 Gerrit-Change-Number: 15997 Gerrit-PatchSet: 16 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2020 18:08:14 +0000 Gerrit-HasComments: Yes
