Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16055 )

Change subject: IMPALA-9844: Ozone support for load data inpath
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

This makes sense to me, one comment on the commit message.

In the context of Ozone support, what tests do we have for Ozone? Are we 
planning to have the ability to run the end to end tests against Ozone?

http://gerrit.cloudera.org:8080/#/c/16055/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16055/2//COMMIT_MSG@12
PS2, Line 12: Removed a workaround in FileSystemUtil#isOzoneFileSystem that 
required
            : CDP jars by default.
I think the workaround allowed it to function without CDP jars. Now, we support 
only CDP and can require the CDP Ozone jars.


http://gerrit.cloudera.org:8080/#/c/16055/2//COMMIT_MSG@15
PS2, Line 15: Change-Id: I60e8c9ebc6c5b2a29539fac9797cbda32e3cc257
Add a line about how you tested it.



--
To view, visit http://gerrit.cloudera.org:8080/16055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60e8c9ebc6c5b2a29539fac9797cbda32e3cc257
Gerrit-Change-Number: 16055
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Sahil Takiar <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 10 Jun 2020 15:59:48 +0000
Gerrit-HasComments: Yes

Reply via email to