Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15814 )
Change subject: IMPALA-9709: Remove Impala-lzo from the development environment ...................................................................... Patch Set 5: (2 comments) Looks good! just a few more updates left as follows: codec.cc => update the message in NO_LZO_MSG HdfsScanNode.java => update VALID_LEGACY_FORMATS HdfsTableSink.java => update SUPPORTED_FILE_FORMATS http://gerrit.cloudera.org:8080/#/c/15814/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15814/5//COMMIT_MSG@11 PS5, Line 11: longer loaded a plugin. LZO tables are not loaded during dataload, nit: as a http://gerrit.cloudera.org:8080/#/c/15814/5/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test File testdata/workloads/functional-query/queries/QueryTest/show-create-table.test: http://gerrit.cloudera.org:8080/#/c/15814/5/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test@a381 PS5, Line 381: nit: i think this test might have been put in to verify INPUTFORMAT and OUTPUTFORMAT syntax. We can probably use alltypes_no_coldef (avro) here instead -- To view, visit http://gerrit.cloudera.org:8080/15814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e Gerrit-Change-Number: 15814 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 10 Jun 2020 20:51:09 +0000 Gerrit-HasComments: Yes
