Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16066 )
Change subject: WIP IMPALA-9482 Support for BINARY columns ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/16066/2/be/src/exec/hbase-table-writer.cc File be/src/exec/hbase-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/16066/2/be/src/exec/hbase-table-writer.cc@157 PS2, Line 157: if (col_desc.auxType().string_subtype == AuxColumnType::StringSubtype::BINARY) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/16066/2/be/src/exec/hdfs-text-table-writer.cc File be/src/exec/hdfs-text-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/16066/2/be/src/exec/hdfs-text-table-writer.cc@103 PS2, Line 103: const ColumnDescriptor& col_desc = table_desc_->col_descs()[num_partition_cols + j]; line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/16066/2/be/src/exec/hdfs-text-table-writer.cc@105 PS2, Line 105: if (col_desc.auxType().string_subtype == AuxColumnType::StringSubtype::BINARY) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/16066/2/be/src/exec/hdfs-text-table-writer.cc@107 PS2, Line 107: Base64Encode(string_value->ptr , string_value->len, &rowbatch_stringstream_); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16066/2/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/16066/2/tests/query_test/test_scanners.py@1535 PS2, Line 1535: class TestBinaryType(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/16066/2/tests/query_test/test_scanners.py@1548 PS2, Line 1548: flake8: W292 no newline at end of file http://gerrit.cloudera.org:8080/#/c/16066/2/tests/query_test/test_udfs.py File tests/query_test/test_udfs.py: http://gerrit.cloudera.org:8080/#/c/16066/2/tests/query_test/test_udfs.py@115 PS2, Line 115: y flake8: E501 line too long (92 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/16066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36861a9ca6c2047b0d76862507c86f7f153bc582 Gerrit-Change-Number: 16066 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 11 Jun 2020 12:01:30 +0000 Gerrit-HasComments: Yes
