Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16050 )
Change subject: IMPALA-9752: aggregate profile stats on executor ...................................................................... Patch Set 4: Code-Review+1 (2 comments) This is making sense to me. http://gerrit.cloudera.org:8080/#/c/16050/4/be/src/runtime/coordinator-backend-state.h File be/src/runtime/coordinator-backend-state.h: http://gerrit.cloudera.org:8080/#/c/16050/4/be/src/runtime/coordinator-backend-state.h@380 PS4, Line 380: instance This is utilization across all the fragment instances, so maybe we should change this variable name? http://gerrit.cloudera.org:8080/#/c/16050/4/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/16050/4/be/src/runtime/query-state.cc@447 PS4, Line 447: // Determine whether this instance had a scan node in its plan. : // Note: this is hacky. E.g. it doesn't work for Kudu scans. : if (entry.second->bytes_read() > 0) { : scan_bytes_sent += entry.second->total_bytes_sent(); : } else { : exchange_bytes_sent += entry.second->total_bytes_sent(); : } Nit: Can use "fis" local variable rather than entry.second -- To view, visit http://gerrit.cloudera.org:8080/16050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2aca354d803ce78a798a1a64f9f98353b813e4a Gerrit-Change-Number: 16050 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 11 Jun 2020 20:39:47 +0000 Gerrit-HasComments: Yes
