Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16057 )
Change subject: WIP - IMPALA-9382: part 2/2: aggregate profiles sent to coordinator ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/16057/6/be/src/runtime/coordinator-backend-state.h File be/src/runtime/coordinator-backend-state.h: http://gerrit.cloudera.org:8080/#/c/16057/6/be/src/runtime/coordinator-backend-state.h@284 PS6, Line 284: /// When --gen_experimental_profile=true, this contains a copy of the full instance I got true/false switched here. We also need to be clearer about *why* it works to merge the partial profile into the aggregated profile. It is quite brittle but does minimise code changes for the moment. I think we need to document in the AggregatedProfile::Update() methods that existing counters and other entities don't get removed if they are updated with a profile that doesn't contain them. -- To view, visit http://gerrit.cloudera.org:8080/16057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic680cbfe94c939c2a8fad9d0943034ed058c6bca Gerrit-Change-Number: 16057 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 11 Jun 2020 22:39:53 +0000 Gerrit-HasComments: Yes
