Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16058 )
Change subject: IMPALA-7538: Support HDFS caching with LocalCatalog ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patch looks good to me. Just a few minor comments below. http://gerrit.cloudera.org:8080/#/c/16058/1/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/16058/1/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java@92 PS1, Line 92: not supported I know this is not used currently, but such messages have a way to sneek into real production deployments when we change defaults. May be just change to "HDFSCachePools are not supported in DirectMetaProvider" http://gerrit.cloudera.org:8080/#/c/16058/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java: http://gerrit.cloudera.org:8080/#/c/16058/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@126 PS1, Line 126: Does not necessarily mean : * the data is cached just for my understanding what does this statement mean? When would a partition be marked as cached but data is not cached? -- To view, visit http://gerrit.cloudera.org:8080/16058 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712 Gerrit-Change-Number: 16058 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Fri, 12 Jun 2020 06:32:43 +0000 Gerrit-HasComments: Yes
