Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15961 )
Change subject: IMPALA-9692 (part 3): Model QuerySchedule as a protobuf ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/15961/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15961/4//COMMIT_MSG@21 PS4, Line 21: This has : been replaced with the ExecParams class > the part I don't fully understand is that doesn't the regular QuerySchedule ignore, offline discussion clarified this http://gerrit.cloudera.org:8080/#/c/15961/4/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/15961/4/be/src/scheduling/admission-controller.h@341 PS4, Line 341: std::unique_ptr<QuerySchedulePB>* schedule_result might be nice to put this in a struct called AdmissionResponse? even if it is just one field, I feel like it makes the code cleaner - the HS2 service follows this Request/Response pattern -- To view, visit http://gerrit.cloudera.org:8080/15961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1db64e72f84604b1d8ac24e0bdd4ad6bedd6bcd9 Gerrit-Change-Number: 15961 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Mon, 15 Jun 2020 23:31:58 +0000 Gerrit-HasComments: Yes
