Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 )
Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. ...................................................................... Patch Set 12: (5 comments) Patch Set 12 add num_backends info in TPlanFragmentInstanceCtx. Using this info, sort node can make a better estimation of how many input data that might be received by each backend, and, if necessary, enforce sort_run_bytes_limit right from the beginning. http://gerrit.cloudera.org:8080/#/c/15963/10/be/src/exec/sort-node.cc File be/src/exec/sort-node.cc: http://gerrit.cloudera.org:8080/#/c/15963/10/be/src/exec/sort-node.cc@199 PS10, Line 199: << " nulls " << (tsort_info. > We usually simply use "Status status = ... ". Done http://gerrit.cloudera.org:8080/#/c/15963/11/be/src/exec/sort-node.cc File be/src/exec/sort-node.cc: http://gerrit.cloudera.org:8080/#/c/15963/11/be/src/exec/sort-node.cc@76 PS11, Line 76: SCOPED_TIMER(runtime_profile_->total_time_counter()); : RETURN_IF_ERROR(ExecNode::Prepare(state)); > I'm not sure my calculation is right here. My assumption is that estimated_ Done. We now piggyback num_backends info through TPlanFragmentInstanceCtx. http://gerrit.cloudera.org:8080/#/c/15963/10/be/src/runtime/sorter.h File be/src/runtime/sorter.h: http://gerrit.cloudera.org:8080/#/c/15963/10/be/src/runtime/sorter.h@160 PS10, Line 160: > typo Done http://gerrit.cloudera.org:8080/#/c/15963/10/be/src/runtime/sorter.h@211 PS10, Line 211: kely go > nit: specifies Done http://gerrit.cloudera.org:8080/#/c/15963/10/be/src/runtime/sorter.h@217 PS10, Line 217: /// Get value of sort_run_bytes_limit query option. If user specifies value between > nit: cases Done -- To view, visit http://gerrit.cloudera.org:8080/15963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a0ba7c4bae4f1d300d4d9d7f594f63ced06a240 Gerrit-Change-Number: 15963 Gerrit-PatchSet: 12 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Jun 2020 15:14:52 +0000 Gerrit-HasComments: Yes
