Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16079 )
Change subject: IMPALA-5904: (part 4) Fix more TSAN bugs ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16079/1/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: http://gerrit.cloudera.org:8080/#/c/16079/1/be/src/runtime/runtime-state.h@155 PS1, Line 155: std::lock_guard<SpinLock> l(query_status_lock_); I think there might be some perf impact here, since this is called in a bunch of loops. I think we either need to validate the perf, or keep the previous pattern, but use an atomic variable for the lock-free check. -- To view, visit http://gerrit.cloudera.org:8080/16079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4244c9a7f971c96b8b8dc7d5262904a0a4b77c1 Gerrit-Change-Number: 16079 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Jun 2020 16:33:41 +0000 Gerrit-HasComments: Yes
