Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16088 )
Change subject: IMPALA-9842: Fix hang when cancelling BufferedPlanRootSink ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16088/1/be/src/exec/buffered-plan-root-sink.cc File be/src/exec/buffered-plan-root-sink.cc: http://gerrit.cloudera.org:8080/#/c/16088/1/be/src/exec/buffered-plan-root-sink.cc@110 PS1, Line 110: if (!state->is_cancelled()) { This is still kinda weird - usually the pattern should be waiting in a loop for some predicate to be true. This could still be vulnerable to spurious wakeups, I think. That wouldn't cause the problem this is fixing, but should probably make this more obviously correct while we're here. -- To view, visit http://gerrit.cloudera.org:8080/16088 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6f3fbc05420ca95313fa79ea106547feb92b16b Gerrit-Change-Number: 16088 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 16 Jun 2020 22:26:06 +0000 Gerrit-HasComments: Yes
