Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16087 )
Change subject: IMPALA-9861: use [[nodiscard]] in gcc ...................................................................... IMPALA-9861: use [[nodiscard]] in gcc This was unblocked by the GCC 7 upgrade. Tested by removing a RETURN_IF_ERROR and making sure there was a compile error. Change-Id: I5290ee36388baef3d43adbde7c684125dbcf3bec Reviewed-on: http://gerrit.cloudera.org:8080/16087 Reviewed-by: Joe McDonnell <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/common/compiler-util.h M be/src/common/status.h 2 files changed, 1 insertion(+), 16 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/16087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5290ee36388baef3d43adbde7c684125dbcf3bec Gerrit-Change-Number: 16087 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
