Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16086 )
Change subject: IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets() ...................................................................... IMPALA-9831: Fix off by one error in condition for ValidateColumnOffsets() ParquetMetadataUtils::ValidateColumnOffsets() returns an error if the end of the column is beyond the end of the file (i.e. offset > end_of_file). Instead, because there is a footer, the end of column must not be the end of the file either, so it should use offset >= end_of_file. Otherwise, a subsequent DCHECK in ParquetPageReader using the stricter condition will fire. Testing: - Core job Change-Id: I16bd6dfbb8eeacc1cb854ed4a3c2ed9f1c3aa11f Reviewed-on: http://gerrit.cloudera.org:8080/16086 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/parquet/parquet-metadata-utils.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I16bd6dfbb8eeacc1cb854ed4a3c2ed9f1c3aa11f Gerrit-Change-Number: 16086 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
