Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16085 )
Change subject: IMPALA-3695: Remove KUDU_IS_SUPPORTED
......................................................................
Patch Set 4: Code-Review+2
This looks safe and a good cleanup.
I did look for things that were missed and only found
common/thrift/generate_error_codes.py: ("KUDU_NOT_SUPPORTED_ON_OS", 74, "Kudu
is not supported on this operating system
I see that TErrorCode::KUDU_NOT_SUPPORTED_ON_OS can still be returned in
CheckKuduAvailability()
Is it worth looking at removing this too? If we wanted to do that it could
certainly be left for a future change.
--
To view, visit http://gerrit.cloudera.org:8080/16085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I059d7a42798c38b570f25283663c284f2fcee517
Gerrit-Change-Number: 16085
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 17 Jun 2020 17:29:56 +0000
Gerrit-HasComments: No
