Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16081 )

Change subject: IMPALA-7533: Cache partitions across table versions in 
LocalCatalog
......................................................................


Patch Set 1:

(1 comment)

> Patch Set 1:
>
> (1 comment)

http://gerrit.cloudera.org:8080/#/c/16081/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java
File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java:

http://gerrit.cloudera.org:8080/#/c/16081/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1635
PS1, Line 1635: partId_ == other.partId_
> Are partition ids globally unique or unique within a table? In other words
Partition ids are globally unique across all tables. They are generated by a 
static counter: 
https://github.com/apache/impala/blob/6ec6aaae8edc552feb3416bebba0ed355c36e46e/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java#L587
So different tables won't have same partition ids.



--
To view, visit http://gerrit.cloudera.org:8080/16081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I512f735b596bc51d553e6d395d108f49727619ed
Gerrit-Change-Number: 16081
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Anurag Mantripragada <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Comment-Date: Thu, 18 Jun 2020 03:05:12 +0000
Gerrit-HasComments: Yes

Reply via email to