Hello Attila Jeges, Joe McDonnell,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/16102

to review the following change.


Change subject: IMPALA-9871: Simplify OS version matching for SLES in 
bootstrap_toolchain.py
......................................................................

IMPALA-9871: Simplify OS version matching for SLES in bootstrap_toolchain.py

bin/bootstrap_toolchain.py failed to recognize SLES12 sp5, which broke
builds on that platform.

This patch simplifies OS version parsing and matching for SLES, omitting
the check for the OS minor version, which shows the SP level for SLES.
This is similar to how Red Hat variants are handled. This gets
rid of the constant update need whenever a new SP level is released for
SLES12.
This is enabled by the native toolchain sharing a single set of artifacts
between all the SLES12 SP levels.

Test: ran a successful build on a SLES12sp5 box.

Change-Id: Id9ada210b915050fbceebb7364e130116e9244d0
---
M bin/bootstrap_toolchain.py
1 file changed, 2 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/16102/1
--
To view, visit http://gerrit.cloudera.org:8080/16102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9ada210b915050fbceebb7364e130116e9244d0
Gerrit-Change-Number: 16102
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Attila Jeges <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>

Reply via email to