Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16059 )
Change subject: IMPALA-9747: More fine-grained codegen for text file scanners ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/16059/10/tests/query_test/test_codegen.py File tests/query_test/test_codegen.py: http://gerrit.cloudera.org:8080/#/c/16059/10/tests/query_test/test_codegen.py@71 PS10, Line 71: assert ("TextConverter::CodegenWriteSlot(): Char isn't supported for CodegenWriteSlot" > I would prefer to keep the parts of the test that are still relevant, so th Done -- To view, visit http://gerrit.cloudera.org:8080/16059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id370193af578ecf23ed3c6bfcc65fec448156fa3 Gerrit-Change-Number: 16059 Gerrit-PatchSet: 10 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 24 Jun 2020 11:48:14 +0000 Gerrit-HasComments: Yes
