Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16103 )
Change subject: IMPALA-9294: Support DATE for min-max runtime filter ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16103/1/be/src/util/min-max-filter.h File be/src/util/min-max-filter.h: http://gerrit.cloudera.org:8080/#/c/16103/1/be/src/util/min-max-filter.h@250 PS1, Line 250: class DateMinMaxFilter : public MinMaxFilter { I think this is identical to TimestampMinMaxFilter but just with Timestamp replaced with Date? If so, can you define it as a template so that we're reducing code duplication? Here and in the .cc file. -- To view, visit http://gerrit.cloudera.org:8080/16103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f6e2dc6949735d5f0fcf317361cc2969a5e82c Gerrit-Change-Number: 16103 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Wed, 24 Jun 2020 22:36:38 +0000 Gerrit-HasComments: Yes
