Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16094 )
Change subject: IMPALA-9691: Support Kudu Timestamp and Date bloom filter ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16094/4/fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java File fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java: http://gerrit.cloudera.org:8080/#/c/16094/4/fe/src/main/java/org/apache/impala/analysis/TimestampTruncationExpr.java@41 PS4, Line 41: public class TimestampTruncationExpr extends Expr { So I'm sorry I didn't think of this before and wasted your time, but I realized I don't think this is actually necessary. There's an existing function called 'utc_to_unix_micros' that does exactly what you're doing here. All you should need to do is create a FunctionCallExpr with that function name in RuntimeFilterGenerator. -- To view, visit http://gerrit.cloudera.org:8080/16094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c1e9bcc9fd6d79a39f25eaa3396188fc0a52a48 Gerrit-Change-Number: 16094 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 25 Jun 2020 20:27:56 +0000 Gerrit-HasComments: Yes
