Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16052 )
Change subject: IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING. ...................................................................... Patch Set 3: (4 comments) CR comments addressed, still working on clean jenkins runs. http://gerrit.cloudera.org:8080/#/c/16052/2/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/16052/2/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@465 PS2, Line 465: // TODO: Remove this when independent subquery evaluation is implemented. > Can we add a simple planner test for this rewrite? With the cardinality che Done http://gerrit.cloudera.org:8080/#/c/16052/2/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@466 PS2, Line 466: // TODO: IMPALA-5100 to cover all cases, we do let through runtime scalars with > It might be helpful to file a separate JIRA with an example of this query, IMPALA-1285 already existed to cover this case, however the way the JIRA is worded in such way to cover the case of detecting these situations at plan time. I had linked this JIRA with IMPALA-5100 which is the blanket issue for runtime scalar checks. Adding IMPALA-9905 to cover the case of queries that can now run after this change. http://gerrit.cloudera.org:8080/#/c/16052/2/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@469 PS2, Line 469: presence > nit: presence Done http://gerrit.cloudera.org:8080/#/c/16052/2/testdata/workloads/functional-query/queries/QueryTest/subquery.test File testdata/workloads/functional-query/queries/QueryTest/subquery.test: http://gerrit.cloudera.org:8080/#/c/16052/2/testdata/workloads/functional-query/queries/QueryTest/subquery.test@1218 PS2, Line 1218: from alltypestiny group by id > nit: remove the functional database name here and below - the test framewor Done -- To view, visit http://gerrit.cloudera.org:8080/16052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I124a58a09a1a47e1222a22d84b54fe7d07844461 Gerrit-Change-Number: 16052 Gerrit-PatchSet: 3 Gerrit-Owner: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sun, 28 Jun 2020 18:16:27 +0000 Gerrit-HasComments: Yes
