Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16119 )
Change subject: IMPALA-9890 (Part 1): Add more TPCDS queries to Impala's test suite ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16119/2/testdata/datasets/tpcds/tpcds_schema_template.sql File testdata/datasets/tpcds/tpcds_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/16119/2/testdata/datasets/tpcds/tpcds_schema_template.sql@1142 PS2, Line 1142: r_reason_id CHAR(16) : r_reason_desc CHAR(100) nit: Why not using STRING? I think at least STRING saves some space. -- To view, visit http://gerrit.cloudera.org:8080/16119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5f260e75a3803aabe9ccef271ba94036f96e5cf Gerrit-Change-Number: 16119 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 29 Jun 2020 02:56:10 +0000 Gerrit-HasComments: Yes
