Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 )
Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/16112/8/fe/src/main/java/org/apache/impala/common/RuntimeEnv.java File fe/src/main/java/org/apache/impala/common/RuntimeEnv.java: http://gerrit.cloudera.org:8080/#/c/16112/8/fe/src/main/java/org/apache/impala/common/RuntimeEnv.java@60 PS8, Line 60: public boolean isGroupingSetsValidationEnabled() { return enableGroupingSetsValidation_; } line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/16112/8/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/16112/8/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@2355 PS8, Line 2355: AnalysisError("select int_col, bool_col, string_col, count(*) from functional.alltypes " + line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/16112/8/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@2363 PS8, Line 2363: AnalysisError("select int_col, bool_col, string_col, count(*) from functional.alltypes " + line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/16112/8/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@2371 PS8, Line 2371: AnalysisError("select int_col, bool_col, string_col, count(*) from functional.alltypes " + line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/16112/8/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/16112/8/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3707 PS8, Line 3707: ParserError("SELECT a FROM foo GROUP BY GROUPING SETS((a, b), GROUPING SETS ((a, b, c), (b, c)))"); line too long (103 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I178e45de94d736630c97ae1ec4a92423cd74621f Gerrit-Change-Number: 16112 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 29 Jun 2020 16:38:27 +0000 Gerrit-HasComments: Yes
