Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16103 )
Change subject: IMPALA-9294: Support DATE for min-max runtime filter ...................................................................... Patch Set 5: (4 comments) Thanks for the feedback! http://gerrit.cloudera.org:8080/#/c/16103/3/be/src/runtime/date-value.h File be/src/runtime/date-value.h: http://gerrit.cloudera.org:8080/#/c/16103/3/be/src/runtime/date-value.h@179 PS3, Line 179: pvalue > No. The caller get pvalue by calling function UpdateFilterParamsPB::mutable Maybe do a DCHECK()? ping. http://gerrit.cloudera.org:8080/#/c/16103/3/be/src/util/min-max-filter-test.cc File be/src/util/min-max-filter-test.cc: http://gerrit.cloudera.org:8080/#/c/16103/3/be/src/util/min-max-filter-test.cc@371 PS3, Line 371: DATE_TIME_CHECK_VALS > It's a micro for CheckTimestampVals and CheckDateVals. I try to keep the na >From the content of this macro, I figured that logic verifies that the filter >is not empty. Thus the comment. Maybe rename it to >DATE_TIME_CHECK_NON_EMPTY_FILTER() or something like that. Technically, you can have another macro on the empty-ness of such a filter. ping. http://gerrit.cloudera.org:8080/#/c/16103/3/be/src/util/min-max-filter.h File be/src/util/min-max-filter.h: http://gerrit.cloudera.org:8080/#/c/16103/3/be/src/util/min-max-filter.h@220 PS3, Line 220: > Don't need to initialize min_ and max_ in constructor since always_false_ i OK. I think the default constructor on min/max is called. http://gerrit.cloudera.org:8080/#/c/16103/3/testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test File testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test: http://gerrit.cloudera.org:8080/#/c/16103/3/testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test@168 PS3, Line 168: functional_kudu.date_tbl a : join [BROADCAST] functional_kudu.date_tbl b > There is 3-way join test case for integer-typed join columns. Since the min My concern is whether the above mentioned 3-way join queries work, based on my previous experiences in adding a new type of filters. Will the new filter work fine with the above two 3-way joins in some unit testing? -- To view, visit http://gerrit.cloudera.org:8080/16103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f6e2dc6949735d5f0fcf317361cc2969a5e82c Gerrit-Change-Number: 16103 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 29 Jun 2020 21:19:24 +0000 Gerrit-HasComments: Yes
