Hello Vihang Karajgaonkar, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16121

to look at the new patch set (#2).

Change subject: IMPALA-9907: Fix NullPointerException in 
ParallelFileMetadataLoader's load() method
......................................................................

IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() 
method

ParallelFileMetadataLoader.loaders_ became a Map, but at one place we
still treat it as a List:

  loaders_.get(i).getPartDir()

'i' is an integer, while the loaders_'s key type is Path.

Unfortunately the code compiled which means we got a
NullPointerException for this statement. I changed the logic to avoid
the NPE.

Testing:

  * Tested manually on an ACID table with deleted rows
  * I didn't add an automated test because I'm about to extend the ACID
    functionalities, hence getting rid of these exceptions
  * The other case when we can hit this NPE is when we get an
    IOException in the file metadata loader's load() method

Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
---
M fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/16121/2
--
To view, visit http://gerrit.cloudera.org:8080/16121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>

Reply via email to