Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16143 )
Change subject: IMPALA-9741: Supported query icebreg table by impala ...................................................................... Patch Set 1: (17 comments) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/analysis/ShowFilesStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowFilesStmt.java: http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/analysis/ShowFilesStmt.java@80 PS1, Line 80: "SHOW FILES not applicable to a non hdfs table and non iceberg table: %s", tableName_)); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@84 PS1, Line 84: // There two cases here: Non-partitioned hdfs table and non-partitioned iceberg table line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@249 PS1, Line 249: public static Map<Integer, String> getPartitionColToSourceIdMap(List<IcebergPartitionSpec> specs) { line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@286 PS1, Line 286: tIcebergTable.setPartition_col_to_source_id_map(icebergTable.getPartitionColToSourceIdMap()); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@309 PS1, Line 309: private static HdfsPartition.FileDescriptor getFileDescriptor(FileSystem fs, Path tableLoc, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@322 PS1, Line 322: return HdfsPartition.FileDescriptor.create(fileStatus, relPath, locations, hostIndex, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@329 PS1, Line 329: public static Map<String, HdfsPartition.FileDescriptor> loadAllPartition(String location, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@337 PS1, Line 337: HdfsPartition.FileDescriptor fileDesc = getFileDescriptor(new Path(file.path().toString()), line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@368 PS1, Line 368: partition.setFileFormat(IcebergUtil.toTHdfsFileFormat(icebergTable.getIcebergFileFormat())); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java: http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java@176 PS1, Line 176: table_.getMetaStoreTable().getParameters().get(IcebergTable.ICEBERG_FILE_FORMAT); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@71 PS1, Line 71: Map<Integer, String> partitionColToSourceIdMap = Utils.getPartitionColToSourceIdMap(partitionSpecs); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@78 PS1, Line 78: ColumnMap cmap, List<IcebergPartitionSpec> partitionSpecs, Map<String, Integer> sourceColsMap, line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@161 PS1, Line 161: localFsTable_.createPrototypePartition(), CatalogObject.ThriftObjectType.DESCRIPTOR_ONLY); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@162 PS1, Line 162: THdfsTable hdfsTable = new THdfsTable(localFsTable_.getHdfsBaseDir(), getColumnNames(), line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@163 PS1, Line 163: localFsTable_.getNullPartitionKeyValue(), FeFsTable.DEFAULT_NULL_COLUMN_VALUE, idToPartition, line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@76 PS1, Line 76: * Get partition info from FeFsTable, we treat iceberg table as an unpartitioned hdfs table line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/16143/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1473 PS1, Line 1473: FeFsTable feFsTable = ((FeIcebergTable) tblRef.getDesc().getTable()).getFeFsTable(); line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I856cfee4f3397d1a89cf17650e8d4fbfe1f2b006 Gerrit-Change-Number: 16143 Gerrit-PatchSet: 1 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 06 Jul 2020 07:21:22 +0000 Gerrit-HasComments: Yes
