Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/16134 )
Change subject: IMPALA-7923: DecimalValue should be marked as packed
......................................................................
Patch Set 3:
I was a little scared since Q1 is a decimal-intensive query, but seems to be
fine when I tried to repro:
Report Generated on 2020-07-07
Run Description: "6c8a3dfc339e43a8992af2ff3429ba5940a061ec vs
513c19bc0a750960b97f0d4cd14a9bdc8bbd2860"
Cluster Name: UNKNOWN
Lab Run Info: UNKNOWN
Impala Version: impalad version 4.0.0-SNAPSHOT RELEASE ()
Baseline Impala Version: impalad version 4.0.0-SNAPSHOT RELEASE (2020-07-01)
+----------+-----------------------+---------+------------+------------+----------------+
| Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) |
Delta(GeoMean) |
+----------+-----------------------+---------+------------+------------+----------------+
| TPCH(30) | parquet / none / none | 10.05 | +0.18% | 10.05 | +0.18%
|
+----------+-----------------------+---------+------------+------------+----------------+
+----------+---------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+------+
| Workload | Query | File Format | Avg(s) | Base Avg(s) |
Delta(Avg) | StdDev(%) | Base StdDev(%) | Iters | Median Diff(%) | MW Zval |
Tval |
+----------+---------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+------+
| TPCH(30) | TPCH-Q1 | parquet / none / none | 10.05 | 10.03 | +0.18%
| 1.16% | 0.64% | 20 | -0.00% | -0.04 | 0.61 |
+----------+---------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+------+
--
To view, visit http://gerrit.cloudera.org:8080/16134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I55f936a4f4f4b5faf129a9265222e64fc486b8ed
Gerrit-Change-Number: 16134
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jul 2020 16:57:14 +0000
Gerrit-HasComments: No
