Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16164 )
Change subject: IMPALA-9940: add missing kudu protobuf deps ...................................................................... IMPALA-9940: add missing kudu protobuf deps Parts of Impala have transitive dependencies on protobuf generated headers from the kudu/ subdirectories, e.g. kudu/util/hash.pb.h. We did not define this dependency in our CMakeLists, so race conditions are possible that cause build failures. This patch fixes the problem by making the gen-deps target depend on the protobuf-generated code in the kudu/ subdirectories. Change-Id: I481d290b424c26da9ec3853d8681c3d6fc34bec6 Reviewed-on: http://gerrit.cloudera.org:8080/16164 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Thomas Tauber-Marshall <[email protected]> --- M CMakeLists.txt M be/src/kudu/rpc/CMakeLists.txt M be/src/kudu/security/CMakeLists.txt M be/src/kudu/util/CMakeLists.txt 4 files changed, 32 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Thomas Tauber-Marshall: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I481d290b424c26da9ec3853d8681c3d6fc34bec6 Gerrit-Change-Number: 16164 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
