Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16171 )

Change subject: IMPALA-9949: fix SELECT list subqueries with HAVING/LIMIT
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16171/5/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java:

http://gerrit.cloudera.org:8080/#/c/16171/5/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@1380
PS5, Line 1380:
              :     // HAVING cause can eliminate any rows produced by the 
statement, therefore we have
              :     // no lower bound on rows returned.
              :     if (exactlyOne && havingClause_ != null && 
!havingClause_.isTriviallyTrue()) {
              :
> It is already handled at L1376.
Done



--
To view, visit http://gerrit.cloudera.org:8080/16171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6034aedac776783bdc8cdb3a2df344e2b3662da6
Gerrit-Change-Number: 16171
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Shant Hovsepian <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Mon, 13 Jul 2020 16:08:22 +0000
Gerrit-HasComments: Yes

Reply via email to