Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 )
Change subject: IMPALA-9917: grouping() and grouping_id() support ...................................................................... Patch Set 15: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16140/15/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java: http://gerrit.cloudera.org:8080/#/c/16140/15/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@132 PS15, Line 132: return (fnName.getDb() == null || fnName.getDb().equals(BuiltinsDb.NAME)) && Maybe add a brief comment about what this case represents http://gerrit.cloudera.org:8080/#/c/16140/15/testdata/workloads/functional-planner/queries/PlannerTest/grouping-sets.test File testdata/workloads/functional-planner/queries/PlannerTest/grouping-sets.test: http://gerrit.cloudera.org:8080/#/c/16140/15/testdata/workloads/functional-planner/queries/PlannerTest/grouping-sets.test@1293 PS15, Line 1293: #constants typo -- To view, visit http://gerrit.cloudera.org:8080/16140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0b1640d606256c0fe9204d2a21a8f6d06abcdb6 Gerrit-Change-Number: 16140 Gerrit-PatchSet: 15 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 13 Jul 2020 19:43:54 +0000 Gerrit-HasComments: Yes
