Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16199 )
Change subject: IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS ...................................................................... Patch Set 6: (2 comments) The solution looks good to me. Only have few comments. http://gerrit.cloudera.org:8080/#/c/16199/6/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/16199/6/tests/authorization/test_ranger.py@830 PS6, Line 830: admin_client.execute("create database {0}".format(unique_database), user=ADMIN) Could you create a function in unique_database and verify it in the show functions result? Some create function ddl examples can be found here: https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/functions-ddl.test http://gerrit.cloudera.org:8080/#/c/16199/6/tests/authorization/test_ranger.py@841 PS6, Line 841: with " : "grant option" Why should we need "with grant option" here? -- To view, visit http://gerrit.cloudera.org:8080/16199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ae7546c206daaf98ecc3de449069027c43c6e1a Gerrit-Change-Number: 16199 Gerrit-PatchSet: 6 Gerrit-Owner: Adam Tamas <[email protected]> Gerrit-Reviewer: Adam Tamas <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 17 Jul 2020 11:39:36 +0000 Gerrit-HasComments: Yes
